Add Worker Maintenance Comment Change to React UI #55547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
Member
|
Nice! Functionality works! a few cleanup suggestions
|
dheerajturaga
approved these changes
Sep 12, 2025
Member
dheerajturaga
left a comment
dheerajturaga
left a comment
There was a problem hiding this comment.
Approving as base functionality works, suggestions are nits which can be addressed in a follow up
Contributor
Author
Thanks for the feedback. (1) is actually a feature and was as far as I remember in the previous UI the same. But can double-check. (2) is a blocker for me, I am not sure why this happens but must be resolved prior merge. Funny it actually updates but does not close. It is the "same" code like in other dialogs but don't understand why it is different here :-D |
Member
|
@jscheffl for 1. I was suggesting we remove the button altogether, no need to have it until the worker enters Maintenance mode |
...dge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceEditCommentButton.tsx
Show resolved
Hide resolved
jscheffl
force-pushed
the
feature/add-maintenance-comment-change-to-edge-react-ui
branch
from
2ff044a to
bbe5ac8
Compare
Contributor
Author
Regarding (1) - with last commit fixed state check in state model, update is now possible also if maintenance is pending. |
Member
|
This last error was about "flask_limiter" error. It's fixed in main now. We should rebase it I think. |
potiuk
force-pushed
the
feature/add-maintenance-comment-change-to-edge-react-ui
branch
from
bbe5ac8 to
c6dafce
Compare
jscheffl
force-pushed
the
feature/add-maintenance-comment-change-to-edge-react-ui
branch
from
c6dafce to
90edd5f
Compare
Contributor
Author
@dheerajturaga It can sometime take a long time until worker is really in maintenance, if a longer running job need to drain. We had it multiple times that we needed to update the comment if the node is still in draining. Therefore I'd not limit the user to update comment. |
jscheffl
force-pushed
the
feature/add-maintenance-comment-change-to-edge-react-ui
branch
from
90edd5f to
625fb94
Compare
gopidesupavan
approved these changes
Sep 13, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Approving , not an UI expert :)
eladkal
approved these changes
Sep 13, 2025
Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
jscheffl
force-pushed
the
feature/add-maintenance-comment-change-to-edge-react-ui
branch
from
625fb94 to
1399d5f
Compare
shahar1
approved these changes
Sep 13, 2025
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
78 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add Worker Maintenance Comment Change to React UI * Review proposal to fix Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com> * Update assets after change * Fix state model, allow update of comment also in pending --------- Co-authored-by: Dheeraj Turaga <dheerajturaga@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the next increment of feature:
Adding a button to change maintenance comments for Edge Workers:
After change:
FYI @dheerajturaga